Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate tcplPlot ggplot bug when type = "sc" verbose = FALSE and compare.val is set #280

Open
cthunes opened this issue Aug 6, 2024 · 0 comments
Assignees
Labels

Comments

@cthunes
Copy link
Contributor

cthunes commented Aug 6, 2024

Error in gList(...) : only 'grobs' allowed in "gList"

Error seems to occur when type = "sc", verbose = FALSE, output is NOT "console", and compare.val is set, and the number of plots is > 1.

@cthunes cthunes self-assigned this Aug 6, 2024
@cthunes cthunes added the bug label Aug 19, 2024
HendricksJudy added a commit to HendricksJudy/CompTox-ToxCast-tcpl that referenced this issue Oct 21, 2024
…er than 1

Fixes USEPA#280

Add condition to handle `compare.val` with multiple plots in `tcplPlot` function.

* **R/tcplPlot.R**
  - Add a condition to check if `compare.val` is set and the number of plots is greater than 1.
  - Modify the `if` condition to handle the case when `compare.val` is set and the number of plots is greater than 1.
  - Ensure that the function does not produce an error when `compare.val` is set and the number of plots is greater than 1.

* **tests/testthat/test-plotting.R**
  - Add a test case to check if `tcplPlot` handles the case when `compare.val` is set and the number of plots is greater than 1.
  - Ensure that the test case verifies that the function does not produce an error in this scenario.
  - Add a test case to check if `tcplPlot` handles the case when `compare.val` is set and the number of plots is greater than 1 with `type` set to 'sc'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant