Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set all b and n wells to 0 conc and after check for any remaining null #181

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

brown-jason
Copy link
Collaborator

closes #180

Copy link
Contributor

@Ashley-Ko Ashley-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this fix works. I was successful in passing this check when running tcplWriteLvl0. However, writing to level 0 was held up by an unrelated issue with the dataset.

@Ashley-Ko Ashley-Ko self-requested a review December 13, 2023 18:20
Copy link
Contributor

@Ashley-Ko Ashley-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to write level 0 with null conc given this change. Looks good to me!

@brown-jason brown-jason merged commit 7df38ec into dev Dec 14, 2023
@brown-jason brown-jason linked an issue Dec 14, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mc0 returning an error with the conc==0
2 participants