Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated *_mthds.R and invitrodb to reflect new method desc #103

Merged

Conversation

Ashley-Ko
Copy link
Contributor

Updated method descriptions to reflect new descriptions now in invitrodb for the following *_mthds.R files: sc1, sc2, mc2, mc3, mc4, mc5, and mc6.

Removed bmed.aeid.lowconc.twells, no.gnls.fit, and nmad.apid.null.zwells and unused commented out functions from from mc4_mthds.R to align with invitrodb.

…odb for the following *_mthds.R files: sc1, sc2, mc2, mc3, mc4, mc5, and mc6.

Removed bmed.aeid.lowconc.twells, no.gnls.fit, and nmad.apid.null.zwells and unused commented out functions from from mc4_mthds.R to align with invitrodb.
R/mc5_mthds.R Outdated
#' \item{log10_2}{Add a cutoff value of log10(2).}
#' \item{neglog2_0.88}{Add a cutoff value of -1*log2(0.88).}
#' \item{bmad3}{Add a cutoff value of 3 multiplied by the baseline median absolute deviation
#' (bmad). By default, bmad is calculated using test compound wells (wllt = t) for the endpoint.}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This by default sentence only applies to single conc. Could replace as "Add a cutoff value of 3 multiplied by the baseline median absolute deviation (bmad) as defined at Level 4."

Updated descriptions for level 6 flags in mc6_mthds.R to reflect new descriptions in invitrodb.

Added self to contributor list in "DESCRIPTION"
Copy link
Collaborator

@brown-jason brown-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run devtools::document() so that the .Rd files that create the manual are updated

Rendered documents using devtools::document() to update the manual.
R/mc6_mthds.R Show resolved Hide resolved
@Ashley-Ko Ashley-Ko requested a review from cthunes July 27, 2023 19:58
Copy link
Collaborator

@madison-feshuk madison-feshuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to be rebased after #102 is merged

@Ashley-Ko Ashley-Ko merged commit 6c3d0a4 into main Jul 31, 2023
1 check passed
@Ashley-Ko Ashley-Ko deleted the 25-update-tcpl-methods-table-descriptions-and-documentation branch July 31, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants