95 update mc6_mthds with fval and fval_unit drops #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madison-feshuk
requested changes
Jul 26, 2023
There was a problem hiding this comment.
This looks good, but dropped column caused error with tcplLoadData: https://github.com/USEPA/CompTox-ToxCast-tcpl/blob/main/R/tcplLoadData.R#L690. Individual columns are selected opposed to whole table
mc6 <- tcplPrepOtpt(tcplLoadData(lvl=6, fld='m4id', val=mc5$m4id, type='mc'))
Error: Unknown column 'fval' in 'field list' [1054]
Kelly-Carstens-EPA
approved these changes
Jul 26, 2023
Rebase main into issue branch for removing fval columns
|
Merged new mc6 method in main and then rebased this branch so I could make the fval changes to the new method. The new method is now updated like the others |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropped fval and fval_unit columns from invitrodb.mc6 and logged changes in schema_changes.
Updated
m6_mthds.Rmethods to not include those columns. Tested withmc(ae=2). Closes #95.