-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initial playwright suite #250
Conversation
✅ Deploy Preview for ghg-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@anayeaye - tagging you here, but I'm not sure who else should review. I can walk through the code in a call, as well. |
nb - currently, this PR includes a change to the VEDA UI git submodule version. That change should be removed from the PR, I guess. |
Thanks for moving this forwards, @stephenkilbourn! Regarding reviews - the Dashboard team (@hanbyul-here, @sandrahoang686) have been looking after the setup of these config repos in the past and would be good to bring in for assessing this. While I think we could consider merging this Playwright setup for a bit of real-world testing in the coming weeks, I would first like for the team to get an understanding of the consequences in terms of maintenance and development overhead this may cause, before we commit to maintaining this longer-term. |
good catch. reverted that in this commit |
Same comment applies here: NASA-IMPACT/veda-ui#835 (comment) |
closing to use work in veda-config for use with veda-deploy: NASA-IMPACT#363 |
This add a Playwright as a possible end to end testing suite. There is a github action that will run the suite on each MR. A developer can also run the tests by the script
yarn test:e2e
.The suite will run the tests in three browsers:
After the test run, the action will attach a report as a zip file. That file will have an html report of the test run. In addition, any failed tests from the run will include a trace that includes network calls and screenshots to allow a developer to walk through the test in an attempt to debug the root cause of failure.