add playwright #363
Open
add playwright #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for visex ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
|
@stephenkilbourn is this still relevant? if so, we should merge this |
|
@slesaad - I caught this up with the features on develop, so it can be merged in and work after an approving review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What am I changing and why
This adds a playwright test suite that generates a list of every catalog and story on the
/data-catalogand/storiesroutes. It ensures that the pages render with the name and that there are no javascript errors on those pages. It is dependent on the changes to the `veda-ui located in NASA-IMPACT/veda-ui#835A follow-up PR can add the github workflow to trigger the test run on each PR once that veda-ui PR is merged. The veda-config will also need a mapbox token added as a github secret.
How to test
run the yarn install to pull in the new dependencies. Run the script
yarn test:e2eto verify that the tests run locally.** To verify that tests catch errors, modify pages to break them and ensure that the test suite finds the failure.** you may be asked to install the playwright browsers on the first run of the test suite.
veda-uisubmodule is needed and only done so if that's the case.