Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BF] valid participant #215

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Conversation

arnaudbore
Copy link
Contributor

Fix #212

@codecov-commenter
Copy link

Codecov Report

Merging #215 (6b79575) into master (3c5ae96) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
- Coverage   78.30%   78.12%   -0.18%     
==========================================
  Files          15       15              
  Lines         885      887       +2     
  Branches      169      170       +1     
==========================================
  Hits          693      693              
- Misses        159      160       +1     
- Partials       33       34       +1     
Flag Coverage Δ
pytest 78.12% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dcm2bids/participant.py 95.12% <0.00%> (-4.88%) ⬇️

Copy link
Member

@SamGuay SamGuay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well thought to allow only alphanum 😄

@arnaudbore arnaudbore merged commit 55f8638 into UNFmontreal:master Jun 29, 2023
@arnaudbore arnaudbore deleted the valid_participant branch July 3, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dcm2bids goes crazy if --participant contains - or _
3 participants