Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDD-2265: Interactive charts on topic pages #533

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+3,404 −306
Open

CDD-2265: Interactive charts on topic pages #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
35aed63
feat: interactive charts
8lane Oct 24, 2024
fddf746
Merge branch 'main' into feat/interactive-charts
8lane Oct 28, 2024
22d29fc
chore: cleanup overrides now that the be supports them
8lane Oct 28, 2024
051173a
chore: tweak lighthouse budget
8lane Oct 28, 2024
3db1711
Merge branch 'main' into feat/interactive-charts
8lane Oct 30, 2024
711b866
Merge branch 'main' into feat/interactive-charts
rhys-burendo Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-test-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
- name: Start Applicaton
run: NODE_ENV=test npm run start &
- name: Unlighthouse assertions and client
run: npx unlighthouse-ci --build-static --site http://localhost:3000/ --budget=80
run: npx unlighthouse-ci --build-static --site http://localhost:3000/ --budget=75
- uses: actions/upload-artifact@v3
if: always()
with:
Expand Down Expand Up @@ -181,7 +181,7 @@ jobs:

publish-image:
name: Publish image to ECR
needs: [ success-gate ]
needs: [success-gate]
runs-on: ubuntu-latest
if: ${{ github.ref == 'refs/heads/main' }}

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lighthouse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
- uses: ./.github/actions/install-cache

- name: Unlighthouse assertions and client
run: npx unlighthouse-ci --build-static --site ${{ env.TARGET_URL }} --budget=80
run: npx unlighthouse-ci --build-static --site ${{ env.TARGET_URL }} --budget=75
- uses: actions/upload-artifact@v3
if: always()
with:
Expand Down Expand Up @@ -103,7 +103,7 @@ jobs:
if: ${{ needs.lighthouse.result == 'failure' }}
with:
status: failure
notification_title: ':warning: {workflow} score has dropped below 80% :warning:'
notification_title: ':warning: {workflow} threshold has dropped :warning:'
message_format: '*{workflow}* {status_message} in <{repo_url}|{repo}@{branch}> on <{commit_url}|{commit_sha}>'
mention_groups: ${{ vars.SLACK_MENTION_USERS }}
mention_groups_when: 'failure,warnings'
Expand Down
Loading
Loading