Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDD-2265: Interactive charts on topic pages #533

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

8lane
Copy link
Contributor

@8lane 8lane commented Oct 24, 2024

Description

PR to add Plotly.js interactivity to our charts.

image
  • Adds only a tooltip for this first phase
  • Uses the new interactive chart feature flag
  • enableInteractive prop added so we can control which areas have plotly.js or not
  • Uses Intersection Observer API to only render the interactive chart when scrolled into view, otherwise fallback to existing static charts
  • Fully progressively enhanced, uses our existing static charts on first load.
  • Refactored chart component be a little more flexible with sizings. It now allows you pass in an array of sizes from the consuming location meaning we don't need the logic contained within the component.

Copy link

github-actions bot commented Oct 24, 2024

Unit tests coverage

Lines Statements Branches Functions
Coverage: 93%
92.27% (1767/1915) 82.68% (401/485) 89.15% (263/295)
Tests Skipped Failures Errors Time
471 0 💤 0 ❌ 0 🔥 16.195s ⏱️

@8lane 8lane force-pushed the feat/interactive-charts branch from b60b307 to 35aed63 Compare October 28, 2024 09:35
@8lane 8lane marked this pull request as ready for review October 28, 2024 09:45
@8lane 8lane force-pushed the feat/interactive-charts branch from d9c6ac5 to 051173a Compare October 28, 2024 10:15
Copy link

sonarqubecloud bot commented Nov 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants