Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements #696

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Minor improvements #696

merged 1 commit into from
Oct 10, 2023

Conversation

jaro-m
Copy link
Contributor

@jaro-m jaro-m commented Oct 10, 2023

Added more testing code

@jaro-m jaro-m self-assigned this Oct 10, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 10, 2023
View reviewed changes
scripts/patchUrls.js
@@ -97,7 +97,15 @@
...process.env
};

console.log("+++ extractEnvVars():", extractEnvVars())
console.log("+++ process.env:", process.env)

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This logs sensitive data returned by
process environment
Loading
as clear text.
@adebayoolabintan adebayoolabintan merged commit 0576fe1 into v3-development Oct 10, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adebayoolabintan adebayoolabintan Awaiting requested review from adebayoolabintan

Assignees

@jaro-m jaro-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaro-m @adebayoolabintan