Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements #696

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Minor improvements #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"lint": "yarn flow",
"start": "unset HOST && react-scripts start",
"build": "unset HOST && export NODE_OPTIONS=--max-old-space-size=8192 && react-scripts build",
"postbuild": "chmod +x scripts/node_heap_size.sh && ./scripts/node_heap_size.sh && node scripts/patchUrls.js --max-old-space-size=8192",
"postbuild": "chmod +x scripts/node_heap_size.sh && ./scripts/node_heap_size.sh && node scripts/patchUrls.js --max-old-space-size=3072",
"ppostbuild": "react-snap",
"test": "react-scripts test",
"eject": "react-scripts eject"
Expand Down
8 changes: 8 additions & 0 deletions scripts/patchUrls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,15 @@
...process.env
};

console.log("+++ extractEnvVars():", extractEnvVars())
console.log("+++ process.env:", process.env)

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This logs sensitive data returned by
process environment
Loading
as clear text.
console.log("+++ Number of files =", files.length)

let counter = 0;

for ( const file of files ) {
counter += 1;
console.log(counter, " - ", file)

const tmpFile = `${ file }.tmp`;

Expand Down
Loading