Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dependency): update babel-code-frame to @babel/code-frame #409

Merged
merged 2 commits into from
May 16, 2020

Conversation

andyrooger
Copy link
Contributor

Update code-frame dependency from v6 to v7 so that we can drop the chalk v1 dependency.

Closes #408

@andyrooger
Copy link
Contributor Author

I've set the dependency to ^7.5.5 because ^7.0.0 has issues with importing @babel/highlight. I can specify latest instead if you prefer though.

johnnyreilly
johnnyreilly previously approved these changes May 16, 2020
@johnnyreilly
Copy link
Member

We seem to have a failing test?

Update code-frame dependency from v6 to v7 so that we can drop the chalk v1 dependency.

Closes TypeStrong#408
@andyrooger
Copy link
Contributor Author

We do... It's failing to clean up after the tests by the look of it.

Each time I run these actions it seems to fail on a different OS using webpack 5, node 8. Can see if it does the same this time, but I'm wondering if this is just an issue with webpack alpha finishing when we expect.

Is there a good way to try these tests on latest master to see if they're still passing repeatably?

@andyrooger
Copy link
Contributor Author

So they're all passing now... all I've changed is the commit author.

@johnnyreilly
Copy link
Member

Flaky tests are the worst! @piotr-oles are you happy for us to merge?

@piotr-oles
Copy link
Collaborator

Looks good. I think we should update the semantic-release config to trigger patch release for refactor commits. Give me a few minutes, I will send you what to change.

@piotr-oles
Copy link
Collaborator

I have created a new PR: #410 to update the semantic-release configuration. We can merge this PR later.

@piotr-oles piotr-oles merged commit 5bdc643 into TypeStrong:master May 16, 2020
@piotr-oles
Copy link
Collaborator

🎉 This PR is included in version 4.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@andyrooger
Copy link
Contributor Author

andyrooger commented May 18, 2020

In case you hadn't already noticed, it looks like refactors don't appear in the release notes even though they do trigger releases. The github release looks blank for 4.1.4. Release itself is working great for me though. :)

@piotr-oles
Copy link
Collaborator

🎉 This PR is included in version 5.0.0-alpha.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

@piotr-oles
Copy link
Collaborator

🎉 This PR is included in version 5.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump babel dependency to @babel/code-frame
3 participants