Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump babel dependency to @babel/code-frame #408

Closed
andyrooger opened this issue May 15, 2020 · 6 comments · Fixed by #409
Closed

Bump babel dependency to @babel/code-frame #408

andyrooger opened this issue May 15, 2020 · 6 comments · Fixed by #409

Comments

@andyrooger
Copy link
Contributor

Feature motivation

I have a large project that's having issues with conflicting versions of chalk being installed. Wrong versions are being picked up in places (which is the individual package's fault).

fork-ts-checker-webpack-plugin has a dependency on babel-code-frame which in turn pulls in chalk@1. For me this is the only package that uses chalk@1 so I'd like to be able to update it.

Looks like the babel package has now been renamed to @babel/code-frame which is where any updates are being published. That depends on chalk@2 so allows me to update and hopefully drop the conflict.

Feature description

Reference the new @babel/code-frame package in package.json to allow users to upgrade it

@johnnyreilly
Copy link
Member

I believe that @piotr-oles has already done the upgrade in the beta he's working on.... I don't know how far away from shipping that is. If it's going to be a while then I suspect we'd be open to a PR 🤗

@piotr-oles
Copy link
Collaborator

The stable version of the plugin will not be released very soon - it's a major rewrite with breaking changes. We will release alpha and beta versions first. So if you don't want to wait, feel free to open a PR :)

@andyrooger
Copy link
Contributor Author

I'll get on it!

andyrooger pushed a commit to andyrooger/fork-ts-checker-webpack-plugin that referenced this issue May 16, 2020
Update code-frame dependency from v6 to v7 so that we can drop the chalk v1 dependency.

Closes TypeStrong#408
andyrooger added a commit to andyrooger/fork-ts-checker-webpack-plugin that referenced this issue May 16, 2020
Update code-frame dependency from v6 to v7 so that we can drop the chalk v1 dependency.

Closes TypeStrong#408
andyrooger added a commit to andyrooger/fork-ts-checker-webpack-plugin that referenced this issue May 16, 2020
Update code-frame dependency from v6 to v7 so that we can drop the chalk v1 dependency.

Closes TypeStrong#408
piotr-oles pushed a commit that referenced this issue May 16, 2020
)

Update code-frame dependency from v6 to v7 so that we can drop the chalk v1 dependency.

Closes #408
@piotr-oles
Copy link
Collaborator

🎉 This issue has been resolved in version 4.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@piotr-oles
Copy link
Collaborator

🎉 This issue has been resolved in version 5.0.0-alpha.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

@piotr-oles
Copy link
Collaborator

🎉 This issue has been resolved in version 5.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants