Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single level per check #579

Merged
merged 14 commits into from
Jul 17, 2024
Merged

Single level per check #579

merged 14 commits into from
Jul 17, 2024

Conversation

reuvenharrison
Copy link
Collaborator

@reuvenharrison reuvenharrison commented Jul 13, 2024

This PR splits checks that have multiple severity levels into multiple checks, each with a single level.
This will allow us to:

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 96.12903% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.92%. Comparing base (ea17e6d) to head (886cc2a).
Report is 3 commits behind head on main.

Files Patch % Lines
checker/rules.go 92.59% 4 Missing ⚠️
checker/config.go 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
+ Coverage   85.89%   85.92%   +0.02%     
==========================================
  Files         228      227       -1     
  Lines       12974    13027      +53     
==========================================
+ Hits        11144    11193      +49     
- Misses       1415     1420       +5     
+ Partials      415      414       -1     
Flag Coverage Δ
unittests 85.92% <96.12%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reuvenharrison reuvenharrison merged commit 9733a40 into main Jul 17, 2024
16 checks passed
@reuvenharrison reuvenharrison deleted the single-level-per-check branch July 17, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant