Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve breaking checks accuracy #580

Closed
reuvenharrison opened this issue Jul 13, 2024 · 0 comments
Closed

Improve breaking checks accuracy #580

reuvenharrison opened this issue Jul 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@reuvenharrison
Copy link
Collaborator

reuvenharrison commented Jul 13, 2024

Oasdiff breaking changes and changelog are currently a best-effort to cover as many possible cases in the most accurate way.
This feature was developed by multiple contributors, each one improving upon previous ones.
Because of its complexity, this feature is still inaccurate which is demonstrated by reported issues (#567, #549...).

I am opening this issue to track a gradual transition to a formalized method that will lead to better accuracy, coverage and the ability to track and measure progress.
Steps:

  1. each check should have a single level
  2. get levels from the rules table rather that redefining them in the code
  3. add the check type into the rules: request vs. response, property/parameter, read-only or read-write...
  4. compare parallel checks to each-other to find discrepancies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant