Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-type-breaking-changes #286

Conversation

reuvenharrison
Copy link
Collaborator

No description provided.

@reuvenharrison reuvenharrison linked an issue Jun 5, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023

Codecov Report

Merging #286 (25fa732) into main (5514bc5) will increase coverage by 0.11%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
+ Coverage   78.19%   78.30%   +0.11%     
==========================================
  Files         161      163       +2     
  Lines        9019     9158     +139     
==========================================
+ Hits         7052     7171     +119     
- Misses       1684     1697      +13     
- Partials      283      290       +7     
Flag Coverage Δ
unittests 78.30% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
checker/check-response-property-type-changed.go 81.48% <100.00%> (+2.60%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@reuvenharrison reuvenharrison merged commit 6629e0d into main Jun 6, 2023
@reuvenharrison reuvenharrison deleted the 280-oasdiff-fails-to-detect-a-breaking-chnage-for-type-change branch June 6, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oasdiff fails to detect a breaking chnage for type change
2 participants