oasdiff fails to detect a breaking chnage for type change

[gssbzn]

Describe the bug
This may be similar to #276 but if I change elements in an array of the response it seems to fail to recognize the breaking change

$ oasdiff -version
oasdiff version: 1.5.14

To Reproduce
Base

openapi: 3.0.1
info:
  title: Test
  version: "2.0"
servers:
- url: http://localhost:8080
tags:
- name: Tests
  description: Test tag.
paths:
  /api/atlas/v2/changeOfResponseArrayFieldTest:
    get:
      tags:
      - Tests
      summary: This is a test
      description: Test description.
      operationId: getTest
      parameters:
      - name: new
        in: query
        description: Test param
        schema:
          type: string
      responses:
        "200":
          description: OK
          content:
            application/vnd.atlas.2023-01-01+json:
              schema:
                type: array
                items:
                  $ref: '#/components/schemas/ChangeOfResponseArrayFieldTestView'
              x-xgen-version: 2023-01-01
      security:
      - DigestAuth: []
components:
  schemas:
    ChangeOfResponseArrayFieldTestView:
      type: object
      properties:
        oldField:
          type: string
          description: A nested view
  securitySchemes:
    DigestAuth:
      type: http
      scheme: digest

Revision

openapi: 3.0.1
info:
  title: Test
  version: "2.0"
servers:
- url: http://localhost:8080
tags:
- name: Tests
  description: Test tag.
paths:
  /api/atlas/v2/changeOfResponseArrayFieldTest:
    get:
      tags:
      - Tests
      summary: This is a test
      description: Test description.
      operationId: getTest
      parameters:
      - name: new
        in: query
        description: Test param
        schema:
          type: string
      responses:
        "200":
          description: OK
          content:
            application/vnd.atlas.2023-01-01+json:
              schema:
                type: array
                items:
                  $ref: '#/components/schemas/ChangeOfResponseArrayFieldTestView'
              x-xgen-version: 2023-01-01
      security:
      - DigestAuth: []
components:
  schemas:
    ChangeOfResponseArrayFieldTestView:
      type: object
      properties:
        newField:
          type: integer
          description: A nested view
          format: int32
  securitySchemes:
    DigestAuth:
      type: http
      scheme: digest

Produces no breaking change

oasdiff -base ChangeOfResponseArrayFieldTest-base.yaml  -revision ChangeOfResponseArrayFieldTest-revision.yaml  -check-breaking
# no result

But produces a correct diff

paths:
    modified:
        /api/atlas/v2/changeOfResponseArrayFieldTest:
            operations:
                modified:
                    GET:
                        responses:
                            modified:
                                "200":
                                    content:
                                        mediaTypeModified:
                                            application/vnd.atlas.2023-01-01+json:
                                                schema:
                                                    items:
                                                        properties:
                                                            added:
                                                                - newField
                                                            deleted:
                                                                - oldField
endpoints:
    modified:
        ?   method: GET
            path: /api/atlas/v2/changeOfResponseArrayFieldTest
        :   responses:
                modified:
                    "200":
                        content:
                            mediaTypeModified:
                                application/vnd.atlas.2023-01-01+json:
                                    schema:
                                        items:
                                            properties:
                                                added:
                                                    - newField
                                                deleted:
                                                    - oldField
components:
    schemas:
        modified:
            ChangeOfResponseArrayFieldTestView:
                properties:
                    added:
                        - newField
                    deleted:
                        - oldField

Expected behavior
I expect a breaking change report

Desktop (please complete the following information):

• OS: macOS 13.4

[reuvenharrison]

Hi @gssbzn ,
This is not considered a breaking-change because the deleted property, 'oldField' isn't defined as required, therefor it is optional and the client should not rely on it being there.
Please let me know if I am missing something.
Reuven

[gssbzn]

Sorry I was busy yesterday and could go back to this

This is not considered a breaking-change because the deleted property, 'oldField' isn't defined as required

This is find if we are being strict on the required for response but I should've probably stick to my original test which was a change of type

base:

openapi: 3.0.1
info:
  title: Test
  version: "2.0"
servers:
- url: http://localhost:8080
tags:
- name: Tests
  description: Test tag.
paths:
  /api/atlas/v2/changeOfResponseArrayFieldTest:
    get:
      tags:
      - Tests
      summary: This is a test
      description: Test description.
      operationId: getTest
      parameters:
      - name: new
        in: query
        description: Test param
        schema:
          type: string
      responses:
        "200":
          description: OK
          content:
            application/vnd.atlas.2023-01-01+json:
              schema:
                type: array
                items:
                  $ref: '#/components/schemas/ChangeOfResponseArrayFieldTestView'
components:
  schemas:
    ChangeOfResponseArrayFieldTestView:
      type: object
      properties:
        testField:
          type: string
          description: A nested view

revision:

openapi: 3.0.1
info:
  title: Test
  version: "2.0"
servers:
- url: http://localhost:8080
tags:
- name: Tests
  description: Test tag.
paths:
  /api/atlas/v2/changeOfResponseArrayFieldTest:
    get:
      tags:
      - Tests
      summary: This is a test
      description: Test description.
      operationId: getTest
      parameters:
      - name: new
        in: query
        description: Test param
        schema:
          type: string
      responses:
        "200":
          description: OK
          content:
            application/vnd.atlas.2023-01-01+json:
              schema:
                type: array
                items:
                  $ref: '#/components/schemas/ChangeOfResponseArrayFieldTestView'
components:
  schemas:
    ChangeOfResponseArrayFieldTestView:
      type: object
      properties:
        testField:
          type: integer
          description: A nested view
          format: int32

is not flagged by

oasdiff -base ChangeOfResponseArrayFieldTest-base.yaml  -revision ChangeOfResponseArrayFieldTest-revision.yaml  -check-breaking