Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-sqlite3 failing on IOJS #385

Closed
c0debreaker opened this issue Jan 15, 2015 · 14 comments
Closed

node-sqlite3 failing on IOJS #385

c0debreaker opened this issue Jan 15, 2015 · 14 comments

Comments

@c0debreaker
Copy link

Today I tried using IOJS. I spoke to few folks at #iojs today in irc. Someone told me to inform you that NaN(https://github.com/rvagg/nan) 1.6 supports iojs now.

I got the error below after executing it:

module.js:324
    throw err;
          ^
Error: Cannot find module '/Users/user01/chartservice/node_modules/sqlite3/lib/binding/node-v42-darwin-x64/node_sqlite3.node'
@kenrick
Copy link

kenrick commented Jan 15, 2015

Got this issue as well, its downloading the wrong binding binary or looking in the wrong place for it.

@springmeyer
Copy link
Contributor

We'll get this working soon. At least these things need to be done:

@c0debreaker
Copy link
Author

Thanks a lot @springmeyer ! :)

@c0debreaker c0debreaker changed the title node-sqlite3 failng on iojs node-sqlite3 failing on iojs Jan 16, 2015
@c0debreaker c0debreaker changed the title node-sqlite3 failing on iojs node-sqlite3 failing on IOJS Jan 16, 2015
@Mithgol
Copy link
Contributor

Mithgol commented Jan 16, 2015

Node-webkit has been renamed to nw.js and its newest versions are based on io.js as well.

The more the merrier, but Windows XP is no longer supported because of nodejs/node#374.

@springmeyer
Copy link
Contributor

@Mithgol - thanks for the details. Sounds like that will need some time to resolve itself. I propose I make a new tag (v3.0.4) of node-sqlite3 today that supports node v0.10.x, v0.11.14, and iojs v1.0.2 and worry about webkit/nw.js support in the coming weeks?

@Mithgol
Copy link
Contributor

Mithgol commented Jan 16, 2015

Okay, though I have a couple of thoughts about it:

  • Currently npm says that version 3.0.4 is already published (2 months ago), so the tag has a reason to be somewhat greater (to indicate that it contains today's changes).
  • Yet another (3.0.5?…) intermediate version of the package (without today's changes) might also be somewhat helpful for people that needed just the ForceSet() changes from Target new v8 from chromium 38 #369 (these changes might fix Failed to build on XP #382 and similar issues) but without iojs-related stuff.

@coolaj86
Copy link
Contributor

What's the work around? Where's the url to the node v0.11 bins so I can just copy them into the node_modules directory myself?

@sdepold
Copy link

sdepold commented Jan 25, 2015

You will have to change the engines selector in the package.json as well. It won't allow you to run sqlite3 on 1.0.x otherwise.

stojanovic added a commit to stojanovic/node-sqlite3 that referenced this issue Feb 1, 2015
@roblabla
Copy link

roblabla commented Feb 9, 2015

Is there a point in having this engine restriction ? Seems more trouble than it's worth, and if nodejs ever comes out of 1.0 in an incompatible way to iojs, it will not even protect anything...

After removing the engine restriction entirely, it seems the master branch of node-sqlite3 happily compiles for iojs

@19h
Copy link

19h commented Feb 10, 2015

npm i --force mapbox/node-sqlite3

@hmalphettes
Copy link

[email protected] installs and works out of the box with iojs-1.2.0
This issue can be closed.

@Mithgol
Copy link
Contributor

Mithgol commented Feb 17, 2015

Okay, closed.

@Mithgol Mithgol closed this as completed Feb 17, 2015
@ItalyPaleAle
Copy link

not working with iojs-2.0.0

@19h
Copy link

19h commented May 5, 2015

@EgoAleSum Please create an issue for that. This issue was about supporting io.js 1.X series; 2.X sports an updated V8 engine and breaks binary support, thus needs a new nan (1.8.4) and / or a variety of modifications throughout the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants