Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for io.js #4811

Closed
stojanovic opened this issue Jan 16, 2015 · 11 comments · Fixed by #4955
Closed

Add support for io.js #4811

stojanovic opened this issue Jan 16, 2015 · 11 comments · Fixed by #4955

Comments

@stojanovic
Copy link

At this moment Ghost works only with Node v0.10.x.

"engines": {
    "node": "~0.10.0"
},
@jgable
Copy link
Contributor

jgable commented Jan 17, 2015

What is the status of Travis CI supporting io.js? I'd vote for waiting to put it in until it was able to be tested with the same rigor as the node engine.

@jaswilli
Copy link
Contributor

What is the status of Travis CI supporting io.js

Support for io.js needs to land in nvm before it can be used on Travis-CI.

Extending on what @jgable said, io.js is (obviously) really new, and there's going to have to be a bit of lag while tooling catches up and the dust settles. At the point when we can easily install it we'll be able to give it a shakedown and see what kind of issues we have with our dependencies, ES6 feature conflicts, etc.

@halfdan
Copy link
Contributor

halfdan commented Jan 17, 2015

As it stands right now the sqlite3 dependency won't build with io.js. Unless the dependencies work properly with io.js there's barely anything we on Ghost can do to support io.js.

@stojanovic
Copy link
Author

@halfdan You're right, but it seems it'll be fixed soon TryGhost/node-sqlite3#385.

@cyrusdavid
Copy link

👍

1 similar comment
@tiefenb
Copy link

tiefenb commented Feb 2, 2015

+1

@halfdan
Copy link
Contributor

halfdan commented Feb 2, 2015

Supposedly travis is going to ship a new version of nvm with io.js support on Tuesday. Happy to pick this up and add io.js to the builds. Which, I think, for now should be an allowed failure. Suggestions?

@stojanovic
Copy link
Author

@halfdan it seems travis is ok now: http://docs.travis-ci.com/user/build-environment-updates/2015-02-03/#io.js-support.
What about node-sqlite3? It works with io.js fine, but travis and appveyor needs to be updated and of course they need to merge pull request etc.

@Julyyq
Copy link

Julyyq commented Feb 4, 2015

+1

@halfdan
Copy link
Contributor

halfdan commented Feb 4, 2015

Sadly they rescheduled the update. Got the PR ready just waiting for Travis to push the change again.

@cyrusdavid
Copy link

👍

halfdan added a commit to halfdan/Ghost that referenced this issue Mar 9, 2015
closes TryGhost#4811, refs TryGhost#4240
- Bump sqlite3 dependency to 3.0.5
- Add node 0.12 and io.js build
ErisDS pushed a commit to ErisDS/Ghost that referenced this issue Mar 9, 2015
fixes TryGhost#4811, refs TryGhost#4240
- Add v0.12 to the build
- Fix express tests to work with iojs/0.12
- Add iojs-v1.2.0 to the build matrix
halfdan added a commit to halfdan/Ghost that referenced this issue Mar 9, 2015
fixes TryGhost#4811, refs TryGhost#4240
- Add v0.12 to the build
- Fix express tests to work with iojs/0.12
- Add iojs-v1.2.0 to the build matrix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants