Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing prototypal i18n code #3802

Merged
merged 1 commit into from
Aug 19, 2014
Merged

Removing prototypal i18n code #3802

merged 1 commit into from
Aug 19, 2014

Conversation

ErisDS
Copy link
Member

@ErisDS ErisDS commented Aug 16, 2014

refs #16, #17, #18, #19, #20, #21, #3801

  • This code was a prototype system built when Ghost was still a prototype.
    It was never fully implemented and hasn't actually worked for ages.
  • Now that the admin is in Ember, it's likely we'll need a very different
    system.

refs #16, #17, #18, #19, #20, #21, TryGhost#3801

- This code was a prototype system built when Ghost was still a prototype.
  It was never fully implemented and hasn't actually worked for ages.
- Now that the admin is in Ember, it's likely we'll need a very different
  system.
ErisDS added a commit that referenced this pull request Aug 19, 2014
Removing prototypal i18n code
@ErisDS ErisDS merged commit e6bb7c4 into TryGhost:master Aug 19, 2014
@hswolff
Copy link
Contributor

hswolff commented Aug 19, 2014

You forgot three instances where node-polygot is used:

Polyglot = require('node-polyglot'),

Polyglot.instance = new Polyglot();

Polyglot = require('node-polyglot'),

@ErisDS
Copy link
Member Author

ErisDS commented Aug 19, 2014

DERP.

@ErisDS ErisDS deleted the i18n branch August 19, 2014 15:00
ErisDS added a commit that referenced this pull request Aug 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants