Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up editor CSS #21

Closed
wants to merge 0 commits into from
Closed

Clean up editor CSS #21

wants to merge 0 commits into from

Conversation

PaulAdamDavis
Copy link

References TryGhost#4373

  • Consistent line-height & padding cross-browser
  • Remove drag handle from textarea
  • Partially clean up the CSS to more closely match the new standard

@ErisDS
Copy link
Owner

ErisDS commented Nov 2, 2014

Also needs some work on line-height I think:

Chrome:
chrome

IE:
IE

Firefox:
firefox

The ideal would be that the left and right side roughly match up in terms of line-height-per-element so that the scroll will always work reasonably nicely.

@PaulAdamDavis
Copy link
Author

Updated with the comments previously on the code.

  • Line height is consistent cross-browser
  • Removes resize handle in the textarea
  • Cleans up CSS a little

Currently, this looks just fine in our target browsers, but I think it's best to leave the bottom padding until scrolling works better, which is being tracked in TryGhost#4373

@ErisDS
Copy link
Owner

ErisDS commented Nov 3, 2014

I think I'm pretty much done with sorting out the scrolling, so it's possibly worth revisiting that bottom padding now :)

Other than that this is looking tonnes better, just needs a rebase and can you fixup the commit message? I'm not going to squish this so it'll go into master ;)

@ErisDS
Copy link
Owner

ErisDS commented Nov 4, 2014

@PaulAdamDavis did you ever get anywhere with fixing the bottom padding?

@PaulAdamDavis
Copy link
Author

Weird. Yesterday, I wasn't able to reproduce to the same extreme as your screenshots :( But today, I see too much padding on the preview, not the editor.

Investigating.

@PaulAdamDavis
Copy link
Author

Despite what I said above, I'm still unable to reproduce :(

Windows 7, Firefox 33
win-7-ff-33

Windows 7, IE 11
win-7-ie-11

Granted there's still a slight inconsistency, with padding, but not to the same level as your screenshots. 😩

@PaulAdamDavis
Copy link
Author

Updated to specify a font-family, which should solve the line-height issues.

@ErisDS ErisDS force-pushed the no-more-codemirror branch 2 times, most recently from 853d11b to 768bfb0 Compare November 14, 2014 11:37
@ErisDS ErisDS force-pushed the no-more-codemirror branch 2 times, most recently from d450485 to 8e06627 Compare November 26, 2014 17:19
@ErisDS
Copy link
Owner

ErisDS commented Nov 30, 2014

I cherry picked this onto my branch :)

@ErisDS ErisDS closed this Nov 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants