-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up editor CSS #21
Clean up editor CSS #21
Conversation
15eb351
to
5709ff1
Compare
Updated with the comments previously on the code.
Currently, this looks just fine in our target browsers, but I think it's best to leave the bottom padding until scrolling works better, which is being tracked in TryGhost#4373 |
5709ff1
to
2cd23a6
Compare
I think I'm pretty much done with sorting out the scrolling, so it's possibly worth revisiting that bottom padding now :) Other than that this is looking tonnes better, just needs a rebase and can you fixup the commit message? I'm not going to squish this so it'll go into master ;) |
@PaulAdamDavis did you ever get anywhere with fixing the bottom padding? |
Weird. Yesterday, I wasn't able to reproduce to the same extreme as your screenshots :( But today, I see too much padding on the preview, not the editor. Investigating. |
Updated to specify a font-family, which should solve the line-height issues. |
853d11b
to
768bfb0
Compare
d450485
to
8e06627
Compare
I cherry picked this onto my branch :) |
References TryGhost#4373