Migrated to bevy 0.9

[John-Toohey]

Does not apply to the platformer example (rapier2d) because we are waiting on dimforge/bevy_rapier#272. When that PR is merged I will update this.

[Trouv]

Thanks for the contribution!

[Trouv]

When that PR is merged I will update this.

Feel free to depend on that PR in main. I'm also down to update that example in a separate PR if it's a lot of changes.

[johanhelsing]

I think

app.add_plugin(bevy_ecs_tilemap::TilemapPlugin)

should probably be removed from LdtkPlugin::build. If more than one plugins does this, the user will get panics like:

thread 'main' panicked at 'Error adding plugin bevy_ecs_tilemap::TilemapPlugin: : plugin was already added in application', C:\Users\Johan\.cargo\registry\src\github.com-1ecc6299db9ec823\bevy_app-0.9.0\src\app.rs:841:63
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Alternatively, put it behind a app.is_plugin_added check.

[johanhelsing]

Not sure if it's this PR, or an existing bevy_ecs_ldtk issue, but I have problems with the background and tiles not lining up:

The white box is the background for the level with the sunnyland grass textures, so either the positions of the background or the tiles is off.

[Trouv]

I have problems with the background and tiles not lining up:

This should be fixed by #136, this PR hasn't pulled from main since that was merged

[John-Toohey]

I think

app.add_plugin(bevy_ecs_tilemap::TilemapPlugin)

should probably be removed from LdtkPlugin::build. If more than one plugins does this, the user will get panics like:

thread 'main' panicked at 'Error adding plugin bevy_ecs_tilemap::TilemapPlugin: : plugin was already added in application', C:\Users\Johan\.cargo\registry\src\github.com-1ecc6299db9ec823\bevy_app-0.9.0\src\app.rs:841:63
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Alternatively, put it behind a app.is_plugin_added check.

Fixed in 90092d8

[John-Toohey]

Rebased based of upstream

[johanhelsing]

Alignment issues gone :)

No other issues

[Trouv]

Pushing a formatting change...

[Trouv]

LGTM. Thanks for your hard work @greenfierydragon and @johanhelsing - I really appreciate it