-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: adjust tile transformations for bevy_ecs_tilemap 0.8 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_centered, change its name accordingly
…match bevy_ecs_tilemap 0.8
Trouv
changed the title
fix!: adjust tile transformations for bevy_ecs_tilemap 0.8 tile position changes
fix!: adjust tile transformations for bevy_ecs_tilemap 0.8
Nov 17, 2022
Thought I fixed it but I think I actually just forgot to pull the bevy_ecs_tilemap update in main woops |
Trouv
force-pushed
the
fix/tile-translations
branch
from
November 17, 2022 05:45
a1074b5
to
f37da11
Compare
…tk into fix/tile-translations
… layer in their names and docs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bevy_ecs_tilemap
0.7 anchored tiles to the bottom-left, while 0.8 anchors tiles to the center.For example, the (0,0) tile used to render the bottom-left pixel of the tile at the origin, but it now renders the center of the tile at the origin.
Since
bevy_ecs_ldtk
adds transforms to tiles, the transform logic needed to be adjusted after updating tobevy_ecs_tilemap
0.8. This PR performs that update, which introduces a breaking change to some utility functionsTo do