Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed npm build #8114

Merged
merged 2 commits into from
Aug 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/pr-npm.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: Build GUI
on: pull_request
jobs:
linux:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Setup npm
uses: actions/setup-node@v4
- name: Build npm
run: |
cd src/tribler/ui/
npm install
npm run build
2 changes: 1 addition & 1 deletion src/tribler/ui/src/pages/Settings/Anonymity.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export default function Anonimity() {

if (!settings) {
(async () => { setSettings(await triblerService.getSettings()) })();
return;
return null;
}

return (
Expand Down
2 changes: 1 addition & 1 deletion src/tribler/ui/src/pages/Settings/Bandwidth.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default function Bandwith() {

if (!settings) {
(async () => { setSettings(await triblerService.getSettings()) })();
return;
return null;
}

return (
Expand Down
2 changes: 1 addition & 1 deletion src/tribler/ui/src/pages/Settings/Connection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default function Connection() {

if (!settings) {
(async () => { setSettings(await triblerService.getSettings()) })();
return;
return null;
}

return (
Expand Down
2 changes: 1 addition & 1 deletion src/tribler/ui/src/pages/Settings/Debugging.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export default function Debugging() {

if (!settings) {
(async () => { setSettings(await triblerService.getSettings()) })();
return;
return null;
}

return (
Expand Down
2 changes: 1 addition & 1 deletion src/tribler/ui/src/pages/Settings/General.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default function General() {

if (!settings) {
(async () => { setSettings(await triblerService.getSettings()) })();
return;
return null;
}

return (
Expand Down
2 changes: 1 addition & 1 deletion src/tribler/ui/src/pages/Settings/Seeding.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default function Seeding() {

if (!settings) {
(async () => { setSettings(await triblerService.getSettings()) })();
return;
return null;
}

return (
Expand Down