Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed npm build #8114

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Fixed npm build #8114

merged 2 commits into from
Aug 26, 2024

Conversation

qstokkink
Copy link
Contributor

Fixes #8113

This PR:

  • Adds a new PR check that builds the GUI.
  • Fixes the return types of the settings pages.

@qstokkink qstokkink changed the title WIP: Fix npm build WIP: Fixed npm build Aug 23, 2024
@qstokkink qstokkink changed the title WIP: Fixed npm build READY: Fixed npm build Aug 23, 2024
@qstokkink qstokkink marked this pull request as ready for review August 23, 2024 12:09
@qstokkink qstokkink mentioned this pull request Aug 23, 2024
Merged
@qstokkink qstokkink changed the title READY: Fixed npm build Fixed npm build Aug 26, 2024
@qstokkink qstokkink merged commit d7eb94e into Tribler:main Aug 26, 2024
7 checks passed
@qstokkink qstokkink deleted the fix_npm_build branch August 26, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoriole xoriole xoriole approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Npm build fails
2 participants
@qstokkink @xoriole