Update pytest configuration to include the --forced-gc option
#7849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code changes in this commit update the pytest configuration to include a new command-line option `--forced-gc`. This option enables forced garbage collection after each test. The `ensure_gc` fixture has been modified to check if the `--forced-gc` option is enabled before triggering garbage collection. This change ensures that all destructors are called and improves test stability, especially when using Libtorrent.
drew2a
requested review from
a team and
kozlovsky
and removed request for
a team
kozlovsky
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7753 by disabling forced garbage collections for tunnel tests and for GUI tests.
There is a possibility that GUI tests may become less stable. If this happens, we should consider reinstating the
ensure_gcfor them. It is uncertain becauseensure_gcwas an experimental feature added when our test suite was quite unstable. Now that it is stable, we can gradually disable experimental features that were implemented to stabilize the test suite.Ref:
ensure_gcfor each test call #7542