Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frozen test: test_anon_download #7753

Closed
drew2a opened this issue Dec 6, 2023 · 8 comments · Fixed by #7849
Closed

Frozen test: test_anon_download #7753

drew2a opened this issue Dec 6, 2023 · 8 comments · Fixed by #7849
Assignees
@drew2a
Labels
component: tests component: tunnels type: bug

Comments

@drew2a
Copy link
Contributor

drew2a commented Dec 6, 2023

#7748
https://github.com/Tribler/tribler/actions/runs/7113705899/job/19366227392?pr=7748#step:6:2732

11:14:43.027 Starting "test_hidden_services"...
src/tribler/core/components/tunnel/tests/test_full_session/test_tunnel_community.py::test_hidden_services PASSED [ 50%] in 14.321s (14 seconds in total)
11:14:57.348 Starting "test_anon_download"...
Timeout (0:01:10)!
Thread 0x0000132c (most recent call first):
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\concurrent\futures\thread.py", line 78 in _worker
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\threading.py", line 870 in run
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\threading.py", line 932 in _bootstrap_inner
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\threading.py", line 890 in _bootstrap

Thread 0x000006bc (most recent call first):
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\concurrent\futures\thread.py", line 78 in _worker
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\threading.py", line 870 in run
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\threading.py", line 932 in _bootstrap_inner
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\threading.py", line 890 in _bootstrap

Thread 0x00001770 (most recent call first):
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\concurrent\futures\thread.py", line 78 in _worker
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\threading.py", line 870 in run
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\threading.py", line 932 in _bootstrap_inner
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\threading.py", line 890 in _bootstrap

Thread 0x00000770 (most recent call first):
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\threading.py", line 306 in wait
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\threading.py", line 558 in wait
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\threading.py", line 1252 in run
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\threading.py", line 932 in _bootstrap_inner
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\threading.py", line 890 in _bootstrap

Thread 0x000010e4 (most recent call first):
  File "D:\a\tribler\tribler\src\tribler\core\conftest.py", line 88 in ensure_gc
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\fixtures.py", line 911 in _teardown_yield_fixture
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\fixtures.py", line 1024 in finish
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\fixtures.py", line 701 in <lambda>
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\runner.py", line 526 in teardown_exact
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\runner.py", line 182 in pytest_runtest_teardown
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\pluggy\_callers.py", line 77 in _multicall
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\pluggy\_manager.py", line 115 in _hookexec
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\pluggy\_hooks.py", line 493 in __call__
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\runner.py", line 262 in <lambda>
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\runner.py", line 341 in from_call
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\runner.py", line 261 in call_runtest_hook
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\runner.py", line 222 in call_and_report
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\runner.py", line 134 in runtestprotocol
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\runner.py", line 114 in pytest_runtest_protocol
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\pluggy\_callers.py", line 77 in _multicall
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\pluggy\_manager.py", line 115 in _hookexec
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\pluggy\_hooks.py", line 493 in __call__
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\main.py", line 350 in pytest_runtestloop
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\pluggy\_callers.py", line 77 in _multicall
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\pluggy\_manager.py", line 115 in _hookexec
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\pluggy\_hooks.py", line 493 in __call__
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\main.py", line 325 in _main
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\main.py", line 271 in wrap_session
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\main.py", line 318 in pytest_cmdline_main
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\pluggy\_callers.py", line 77 in _multicall
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\pluggy\_manager.py", line 115 in _hookexec
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\pluggy\_hooks.py", line 493 in __call__
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\config\__init__.py", line 169 in main
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\config\__init__.py", line 192 in console_main
  File "C:\Users\runneradmin\.virtualenvs\.venv\Scripts\pytest.exe\__main__.py", line 7 in <module>
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\runpy.py", line 87 in _run_code
  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\runpy.py", line 194 in _run_module_as_main
@qstokkink
Copy link
Contributor

It seems like this is the culprit:

Thread 0x000010e4 (most recent call first):
  File "D:\a\tribler\tribler\src\tribler\core\conftest.py", line 88 in ensure_gc
  File "c:\users\runneradmin\.virtualenvs\.venv\lib\site-packages\_pytest\fixtures.py", line 911 in _teardown_yield_fixture

The teardown of this fixture is only a single line of code:

tribler/src/tribler/core/conftest.py

Line 88 in 0d9a839

gc.collect()

@drew2a
Copy link
Contributor Author

drew2a commented Dec 8, 2023

The PR where this line was introduced:

@qstokkink
Copy link
Contributor

@drew2a I don't see test_anon_download in the lists of flaky tests linked to that PR. Can we disable the ensure_gc fixture for test_anon_download?

@drew2a
Copy link
Contributor Author

drew2a commented Dec 8, 2023

Can we disable the ensure_gc fixture for test_anon_download?

I guess so. gc.collect() was a quite experimental attempt to stabilize the test suite.

@drew2a
Copy link
Contributor Author

drew2a commented Dec 11, 2023

Occurred again https://github.com/Tribler/tribler/actions/runs/7143968388/job/19456591244?pr=7764#step:6:2744 in #7764

@drew2a
Copy link
Contributor Author

drew2a commented Jan 17, 2024

Occurred again https://github.com/Tribler/tribler/actions/runs/7556728538/job/20574404232?pr=7833

@drew2a
Copy link
Contributor Author

drew2a commented Jan 23, 2024

Occurred again https://github.com/Tribler/tribler/actions/runs/7614277672/job/20736190285?pr=7843#step:6:2717

@drew2a
Copy link
Contributor Author

drew2a commented Jan 24, 2024

Occurred again https://github.com/Tribler/tribler/actions/runs/7636254611/job/20803020162?pr=7843#step:6:2724

@drew2a drew2a self-assigned this Jan 24, 2024
@drew2a drew2a added this to the 7.14.0 milestone Jan 24, 2024
@drew2a drew2a mentioned this issue Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drew2a drew2a

Labels
component: tests component: tunnels type: bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update pytest configuration to include the --forced-gc option drew2a/tribler
2 participants
@qstokkink @drew2a