[WIP] Replace lambdas with function calls #7441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace lambdas with function calls. This was done either by extracting a lambda into a function or method, or by replacing it with a library function call.
The `u` prefix was removed from strings. Instead of using the `%` operator with strings or concatenating multiple of them, f-strings were used. Replaced complex one-like if-else chains with dicts and calls to `dict.get`. Instead of creating lists and adding them (which returns a new list), a list is created from the get-go by extending it via the star operator during its creation.
Bumps [requests](https://github.com/psf/requests) from 2.25.1 to 2.31.0. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.25.1...v2.31.0) --- updated-dependencies: - dependency-name: requests dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
|
Recent rebasing from upstream messed up my PR commits. Because of this, I'm closing this pull request and opening a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace lambdas with function calls. This was done either by extracting a lambda into a function or method, or by replacing it with a library function call.
This PR fixes #7432