Extract lambdas into functions to improve readability and ease maintenance

[Solomon1732]

Describe the bug

Extracting lambdas

I noticed there are three lambda declarations. They look to me like they would benefit from being extracted into functions (in the style of _function_name). Each suggestion is below each link. Note I gave placeholder names to extracted functions. They're not full-blown names.

tribler/src/tribler/core/components/tunnel/community/dispatcher.py

Line 123 in 8df8154

circuit.ready.add_done_callback(lambda f, c=connection.udp_connection, r=request:

...
def select_circuit(self, connection, request):
    def _add_data_if_result(result_func, connection=connection_udp_connection, request=request):
        if not result_func.result():
            return None
        return self.on_socks5_udp_data(connection, request)

...
            circuit.ready.add_done_callback(_add_data_if_result)

tribler/doc/conf.py

Line 52 in 8df8154

RootEndpoint.add_endpoint = lambda self, path, ep: add_endpoint(self, path, ep) \

def _add_endpoint(add_endpoint):
    if path in ['/ipv8', '/market', '/wallets']:
        return None
    return add_endpoint(self, path, ep)
...
with patch_import(modules):
    from tribler.core.components.restapi.rest.root_endpoint import RootEndpoint

    add_endpoint = RootEndpoint.add_endpoint
    RootEndpoint.add_endpoint = _add_endpoint

tribler/src/tribler/core/components/tunnel/community/tunnel_community.py

Line 506 in 8df8154

callback=lambda addr, ih=info_hash: self.on_e2e_finished(addr, ih))

import functools
...
    def monitor_downloads(self, dslist):
...
                    self.join_swarm(info_hash, hops[info_hash], seeding=new_state == DownloadStatus.SEEDING,
                                    callback=functools.partial(self.on_e2e_finished, info_hash=info_hash))

Replacing lambdas with built-ins or library functions

These lambdas can be replaces with built-in functions or library ones, mainly from the python library operator module.

tribler/src/tribler/core/components/reporter/reported_error.py

Line 10 in 8df8154

additional_information: dict = field(default_factory=lambda: {}, repr=False)

    additional_information: dict = field(default_factory=dict, repr=False)

tribler/src/tribler/gui/widgets/graphs/timeseriesplot.py

Line 48 in 8df8154

self.plot_data = dict(sorted(self.plot_data.items(), key=lambda x: x[0]))

import operator
...
        self.plot_data = dict(sorted(self.plot_data.items(), key=operator.itemgetter(0))

tribler/src/tribler/gui/dialogs/feedbackdialog.py

Line 130 in 8df8154

sys_info_dict = defaultdict(lambda: [])

        sys_info_dict = defaultdict(list)

tribler/src/tribler/gui/widgets/graphs/timeseriesplot.py

Line 48 in 8df8154

self.plot_data = dict(sorted(self.plot_data.items(), key=lambda x: x[0]))

import operator
...
        self.plot_data = dict(sorted(self.plot_data.items(), key=operator.itemgetter(0))

tribler/src/tribler/core/components/metadata_store/restapi/search_endpoint.py

Line 60 in 8df8154

torrents_list.sort(key=lambda x: x["num_seeders"], reverse=True)

import operator
...
            torrents_list.sort(key=operator.itemgetter("num_seeders"), reverse=True)

tribler/src/tribler/core/components/gigachannel/community/gigachannel_community.py

Line 50 in 8df8154

removed_peer = min(channel_peers, key=lambda x: x.last_response)

import operator
...
            removed_peer = min(channel_peers, key=operator.attrgetter("last_response"))

tribler/src/tribler/core/components/gigachannel/community/gigachannel_community.py

Line 67 in 8df8154

return sorted(channel_peers, key=lambda x: x.last_response, reverse=True)[0:limit]

import operator
...
        return sorted(channel_peers, key=operator.attrgetter("last_response"), reverse=True)[0:limit]

tribler/src/tribler/gui/widgets/downloadsdetailstabwidget.py

Line 30 in 8df8154

for file in sorted(files, key=lambda x: x['index']):

import operator
...
    for file in sorted(files, key=operator.attrgetter("index")):```

tribler/src/tribler/core/components/libtorrent/download_manager/download_manager.py

Line 255 in 8df8154

ltsession.pop_alerts = lambda: {}

            ltsession.pop_alerts = dict

• Tribler's version [main branch]

[drew2a]

@Solomon1732 thank you for your contributions to improving Tribler's code quality. If it's not too much trouble, could you kindly convert this issue into a pull request? This way, we could avoid duplication of work, as it would save us the step of implementing the string replacements that you've described. Plus, we could run tests on the modified code to ensure its correctness.
Thank you in advance for your consideration.

[Solomon1732]

No problem. I would be glad to 😄