Fix api_key conversion in DebugWindow #6613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_key is already str now
kozlovsky
requested review from
a team,
xoriole and
ichorid
and removed request for
a team
|
Kudos, SonarCloud Quality Gate passed!
|
|
retest this please |
ichorid
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously GUI process stores
api_keyvalue mostly as bytes (and sometimes as str, which caused problems), and now it after #6608 and #6611, it is always stored as str. When displayingapi_keyin DebugWindow, the conversion from bytes to str is not needed anymore, asapi_keyis already str.