Fix api_key encoding/decoding #6608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
kozlovsky
force-pushed
the
fix/api_key_encoding
branch
4 times, most recently
from
abc932e to
726e658
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
retest this please |
kozlovsky
requested review from
a team and
drew2a
and removed request for
a team
drew2a
approved these changes
Dec 2, 2021
| @@ -37,7 +37,7 @@ def __init__(self, api_port, api_key, error_handler): | |||
| QNetworkAccessManager.__init__(self) | |||
| url = QUrl("http://localhost:%d/events" % api_port) | |||
| self.request = QNetworkRequest(url) | |||
| self.request.setRawHeader(b'X-Api-Key', api_key) | |||
| self.request.setRawHeader(b'X-Api-Key', api_key.encode('ascii')) | |||
There was a problem hiding this comment.
Question: are you sure that 'ascii' is the correct encoding?
There was a problem hiding this comment.
Yes, because we construct api_key as hexlify(os.urandom(16)). It contains ASCII symbols only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6607 by fixing encoding/decoding of
api_key.