Fill in PR Parameters #21940

[vedantmgoyal9]

• Have you signed the Contributor License Agreement?
• Have you checked that there aren't other open pull requests for the same manifest update/change?
• Have you validated your manifest locally with winget validate --manifest <path>?
• Have you tested your manifest locally with winget install --manifest <path>?
• Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

---

Fixes microsoft#21940

[vedantmgoyal9]

@OfficialEsco Please test this version of YamlCreate.ps1

[OfficialEsco]

This part does not work at all

Does this pull request resolve any issues?
Enter issue number. For example: 21983, 43509
[Y] Yes  [N] No (default is 'N'): 2
Warning: 1 uncommitted change

Also you don't actually need the $PSScriptRoot\..\.github\PULL_REQUEST_TEMPLATE.md part,
You can do

if ($Task -eq Yes) {
$PRTemplate += "`n[X] Task"
} else {
$PRTemplate += "`n[ ] Task"
}

or maybe you could use the PR Template as a Schema?

$PRTemplate = Get-Content -path $PSScriptRoot\..\.github\PULL_REQUEST_TEMPLATE.md
foreach ($Line in $PRTemplate {
  Prompt Line without [ ]
  If yes [X] insert else insert [ ]
} 

[OfficialEsco]

I have fixed this part.

Yap less confusing now

I first tried to use $PrBody = Get-Content -path $PSScriptRoot...github\PULL_REQUEST_TEMPLATE.md, then replace it as you mentioned, but GitHub CLI does not take it line by line and what you will get is a string like this, that's why I need to write such a long function.

Took me waaay too long to test gh pr create 🤦‍♂️ You're right, it actually needs a file.. thats dumb

What do you think of something like this? (Testing draft)

Function Enter-PR-Parameters {
    Clear-Variable PrBodyContentReply
    $PrBodyContent = Get-Content -Path "$env:USERPROFILE\Github\winget-pkgs\.github\PULL_REQUEST_TEMPLATE.md" 

    ForEach ($_ in ($PrBodyContent | Where-Object { $_ -like '-*[ ]*' })) {
        if ($_ -like "*winget validate*") {
            $PrBodyContentReply += $_.Replace("[ ]","[X]"), "`n"
        } else {
            Write-Host
            Write-Host
            Write-Host -ForegroundColor 'White' $_.TrimStart("- [ ]")
            Write-Host -ForegroundColor 'White' -NoNewline "[Y] Yes  "
            Write-Host -ForegroundColor 'Yellow' -NoNewline "[N] No "
            Write-Host -NoNewline "(default is 'N'): "
            do {
                $keyInfo = [Console]::ReadKey($false)
            } until ($keyInfo.Key)
            if ($keyInfo.Key -eq 'Y') {
                $PrBodyContentReply += $_.Replace("[ ]","[X]"), "`n"
            } else {
                $PrBodyContentReply += $_, "`n"
            }
        }
    }

    Write-Host
    Write-Host
    Write-Host -ForegroundColor 'White' "Does this pull request resolve any issues?"
    Write-Host -ForegroundColor 'White' -NoNewline "[Y] Yes  "
    Write-Host -ForegroundColor 'Yellow' -NoNewline "[N] No "
    Write-Host -NoNewline "(default is 'N'): "
    do {
        $keyInfo = [Console]::ReadKey($false)
    } until ($keyInfo.Key)
    if ($keyInfo.Key -eq 'Y') {
        Write-Host
        Write-Host "Enter issue number. For example`: 21983, 43509"
        $ResolvedIssues = Read-Host -Prompt 'Resolved Issues' | TrimString
        Foreach($i in ($ResolvedIssues.Split(","))) {
            $PrBodyContentReply += "Resolves #$i`n"
        }
    } else {Write-Host}

    Write-Host
    $PrBodyContentReply = ($PrBodyContentReply.Trim() -ne '')
    $PrBodyContentReply

    #Set-Content -Path PrBodyFile -Value $PrBodyContentReply | Out-Null
    #gh pr create --body-file PrBodyFile -f
    #Remove-Item PrBodyFile
}

I have this issue:

Does this pull request resolve any issues?
[Y] Yes  [N] No (default is 'N'): y
Enter issue number. For example: 21983, 43509
Resolved Issues: 123, 1234

- [X] Have you signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs)?
- [X] Have you checked that there aren't other open [pull requests](https://github.com/microsoft/winget-pkgs/pulls) for the same manifest update/change?
- [X] Have you validated your manifest locally with `winget validate --manifest <path>`?
- [X] Have you tested your manifest locally with `winget install --manifest <path>`?
- [X] Does your manifest conform to the [1.0 schema](https://github.com/microsoft/winget-cli/blob/master/doc/ManifestSpecv1.0.md)?
Resolves #123
Resolves # 1234

For no space i have to do Resolved Issues: 123,1234

Dunno if its because i've messed with your part

Also i agree the Test-Manifest should not be there 😁
Also the script already runs winget validate, so i don't think there is a reason for it do do it again so we just check validate automatically .

[OfficialEsco]

Fixed in commit 4f24c84... Now i think everything is perfect...

What, I swear I tested that and it had no effect... Probably broke something on my end

won't he will be going through a kind of weird prompts?

Yeeah it looks ugly, you can make a elseif for a custom prompt like the winget validate part, also if user selected yes to test in Sandbox the winget install prompt should be checked automatically with a elseif

I originally tried to do that part with switch but I don't understand it >:c

[OfficialEsco]

I use the Default Powershell (5.1.19041.1023) which comes with Windows 10 for compatibility, but our code is a tiny bit different since you haven't implemented the simplified prompts yet 😁 so we'll see where i messed up once you implement it since i believe you need to do the variable part differently👍

Let me know when its implemented :)

[OfficialEsco]

Naaaaaah tbh it looks cleaner without the 2 last lines, the note is just to inform how to do winget install and winget validate
And the ----- like have no function, and if we type something above it the text will be huge 🤦‍♂️

BIG TEXT
-----

Normal text

-----

[OfficialEsco]

Uhoh something gone wrong
microsoft#23909
You need a function like this somewhere i believe

$PrBodyContentReply = ($PrBodyContentReply.Trim() -ne '')

[OfficialEsco]

https://desktop.githubusercontent.com/releases/2.4.3-539849ed/GitHubDesktopSetup.msi I think it should be removed.

This XML file does not appear to have any style information associated with it. The document tree is shown below.
<Error>
<Code>ResourceNotFound</Code>
<Message>The specified resource does not exist. RequestId:cb182efa-d01e-004f-0a1a-8a5a9d000000 Time:2021-08-05T16:51:13.2113922Z</Message>
</Error>

But if you are talking about the GitHub Desktop Machine Wide installer we're waiting for Schema v1.1.0

[OfficialEsco]

Uhhh i just checked a few URLs and they all fail up to the latest 2.9.0
https://desktop.githubusercontent.com/releases/2.9.0-4806a6dc/GitHubDesktopSetup-x64.msi and https://desktop.githubusercontent.com/releases/2.9.0-4806a6dc/GitHubDesktopSetup-x64.exe

[OfficialEsco]

Yup seems like they changed the URL's and the older versions are still not accessable
https://desktop.githubusercontent.com/github-desktop/releases/2.9.0-4806a6dc/GitHubDesktopSetup-x64.exe
https://desktop.githubusercontent.com/github-desktop/releases/2.9.0-4806a6dc/GitHubDesktopSetup-x64.msi

Guess it dosn't hurt to purge the package

[OfficialEsco]

PFN?

Also about FamilyName and SignatureSha, i've searched around for this before, and from what i found is that it has very little information and support, FamilyName can be found by installing the software and doing get-appxpackage, SignatureSha i have no idea how to read, but for some reason they built it into winget hash

[denelon]

@vedantmgoyal2009 as you make improvements/suggestions to YamlCreate, would you mind considering adding new features to the Windows Package Manager Manifest Creator? We will be making this an optional package for the Windows Package Manager so one can winget create. We do want to have full fidelity. There may already be sample code for doing some of the things you're asking about.

[denelon]

The wingetcreate.exe detects many of these properties.

[OfficialEsco]

Also you need to change this

switch ($keyInfo.Key) {
            'Y' { $SandboxTest = '0' }
            'N' { $SandboxTest = '1' }
            default { $SandboxTest = '0' }
        }

to this

switch ($keyInfo.Key) {
            'Y' { $script:SandboxTest = '0' }
            'N' { $script:SandboxTest = '1' }
            default { $script:SandboxTest = '0' }
        }

for if ($script:SandboxTest -eq '0') { to work since its in another function

Solved

[OfficialEsco]

Do this #4 (review), i can't suggest changes since its outside of the changed scope

[OfficialEsco]

As far as I'm aware this is 👌