Replaced PrBodyContentReply `n with array

[OfficialEsco]

I just learned the use of @() 🤦‍♂️
Needed the space on line 983 to make the PR look less cluttered

[Trenly]

@OfficialEsco I’m wondering if we can abstract the switch a bit further now that we have the standardized menus.

Soemthing like:

Function
  For each line
    Switch -Wildcard
        Set the menu options, don’t display menu
    End switch
    Display menu and replace line
  Next line
End function

The more I think about it though, the more I believe the KeypressMenu function would need to be adjusted to handle empty strings. I can handle this in a separate PR

[OfficialEsco]

Think its best if you just show it in action, but usually your functions make a lot more sense 😁

[Trenly]

All comments are just minor suggestions and could be handled in a separate PR

[Trenly]

I know its a bit outside the scope of your changes, but is there any way for us to validate the issue exists? Maybe using Invoke-WebRequest and checking the return status code?

Also, I know this isn’t your fault, but the way the issues are handled makes it so if someone entered microsoft/winget-cli/#1234 or #1234 it wouldn’t properly link the resolves. I think we need to have separate logic handling for if the $i has a # in it already

[OfficialEsco]

I was actually thinking the same thing, not sure how well the # matching is, but technically it can match towards a old PR or Issue which is not supposed to be closed, the tips does however say to use 123, 1234 instead of #123 or microsoft/winget-cli/#1234 tho

You can probably make it safer in another PR since you sorta already have a plan and know what you are doing 😁
Ill just jump in with my suggestions and stress test it 👍

[OfficialEsco]

Off topic: i have/had a issue when fetching some patterns from the Schema, for example i would like the Pattern from PackageVersion which is ^[^\\\\/:\\*\\?\"<>\\|\\x01-\\x1f]+$ however the output turned into something like ^[^\/:\*\?\"<>\|\x01-\x1f]+$ which obviously did not work

Do you have a workaround for this?

[Trenly]

Do you have specific line numbers that I can look at?

[OfficialEsco]

Line 176 i want
-and ($PackageVersion -notmatch $InstallerSchema.definitions.PackageVersion.pattern)

You can test this

$InstallerSchema = @(Invoke-WebRequest 'https://raw.githubusercontent.com/microsoft/winget-cli/master/schemas/JSON/manifests/v1.0.0/manifest.installer.1.0.0.json' -UseBasicParsing | ConvertFrom-Json)
$InstallerSchema.definitions.PackageVersion.pattern

Output: ^[^\\/:\*\?"<>\|\x01-\x1f]+$ expected ^[^\\\\/:\\*\\?\"<>\\|\\x01-\\x1f]+$