This repository has been archived by the owner on Jul 21, 2022. It is now read-only.
Update Catch2 version to fix build error with recent glibc versions #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Could you rebase this branch onto master? I have fixed the formatting issues that fail in this PR. |
|
That was fast. Thank you! |
|
Alright, rebased it. |
|
Thank you so much. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent glibc versions (appears to be 2.34) made
MINSIGSTKSZnon-constant, which broke Catch2. This has been fixed in the most recent Catch2 release, however TrenchBroom and Vecmath are out of date and thus do not build with recent glibc versions, such as that used in Fedora Rawhide and Arch Linux.This pull request simply updates the used Catch2 version to fix this. I have verified that this now builds on Arch Linux which was affected by the problem.
Related: catchorg/Catch2#2178 gabime/spdlog#1899 puppetlabs/cpp-hocon#132
Note: This pull request applies for both vecmath and TrenchBroom, and will be posted for both.
TrenchBroom PR: TrenchBroom/TrenchBroom#3958