1.8.5 build failure on GCC 11

[xvitaly]

Failed to build version 1.8.5 on Fedora 35.
GCC version: 11.0.1 (snapshot).

[21/30] /usr/bin/g++ -DFMT_LOCALE -DFMT_SHARED -DSPDLOG_COMPILED_LIB -DSPDLOG_FMT_EXTERNAL -DSPDLOG_SHARED_LIB -I../include -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -DNDEBUG -std=c++11 -MD -MT tests/CMakeFiles/spdlog-utests.dir/main.cpp.o -MF tests/CMakeFiles/spdlog-utests.dir/main.cpp.o.d -o tests/CMakeFiles/spdlog-utests.dir/main.cpp.o -c ../tests/main.cpp
FAILED: tests/CMakeFiles/spdlog-utests.dir/main.cpp.o 
/usr/bin/g++ -DFMT_LOCALE -DFMT_SHARED -DSPDLOG_COMPILED_LIB -DSPDLOG_FMT_EXTERNAL -DSPDLOG_SHARED_LIB -I../include -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -DNDEBUG -std=c++11 -MD -MT tests/CMakeFiles/spdlog-utests.dir/main.cpp.o -MF tests/CMakeFiles/spdlog-utests.dir/main.cpp.o.d -o tests/CMakeFiles/spdlog-utests.dir/main.cpp.o -c ../tests/main.cpp
In file included from /usr/include/signal.h:315,
                 from ../tests/catch.hpp:6323,
                 from ../tests/main.cpp:2:
../tests/catch.hpp:9041:58: error: call to non-'constexpr' function 'long int sysconf(int)'
 9041 |     constexpr static std::size_t sigStackSize = 32768 >= MINSIGSTKSZ ? 32768 : MINSIGSTKSZ;
      |                                                          ^~~~~~~~~~~
In file included from /usr/include/bits/sigstksz.h:24,
                 from /usr/include/signal.h:315,
                 from ../tests/catch.hpp:6323,
                 from ../tests/main.cpp:2:
/usr/include/unistd.h:630:17: note: 'long int sysconf(int)' declared here
  630 | extern long int sysconf (int __name) __THROW;
      |                 ^~~~~~~
In file included from ../tests/main.cpp:2:
../tests/catch.hpp:9100:45: error: size of array 'altStackMem' is not an integral constant-expression
 9100 |     char FatalConditionHandler::altStackMem[sigStackSize] = {};
      |                                             ^~~~~~~~~~~~

Full build log: https://kojipkgs.fedoraproject.org//work/tasks/568/65020568/build.log

[gabime]

It is build error of catch2 lib, not spdlog’s.

[xvitaly]

It is build error of catch2 lib, not spdlog’s.

Yes, bundled into spdlog catch. I think it need to be updated.

[gabime]

Could you check if newer version of catch fix this?

[xvitaly]

Could you check if newer version of catch fix this?

catchorg/Catch2#2178

[xvitaly]

I will try to use packaged version of Catch.

[xvitaly]

Packaged version works fine.

[gabime]

Packaged version works fine.

You mean spdlog’s bundled version? or latest version(2.3.14) from catch repo?

[xvitaly]

You mean spdlog’s bundled version? or latest version(2.3.14) from catch repo?

Patched version 2.13.4 from Fedora repositories.

I think you can update bundled version with included patch.