Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed to make TestHarness full runnable (on my machine) #4

Closed
wants to merge 1 commit into from
+10 −0
Closed

fixed to make TestHarness full runnable (on my machine) #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ __pycache__
*.egg-info
logs/
Translator-Tests/
build/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does build/ come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure. that's more common with Javascript builds, right - none here. I don't think it is relevant to this, unless the UI testing is somehow creating it, LOL. I'll try to remove it.

test_ars.log

# PyCharms IDE metadata to be ignored
.idea/
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,8 @@ The Test Harness is a CLI that you need to install:
- `pip install -r requirements-runners.txt` to install the Test Runners
- `pip install .` to install the Test Harness CLI

Create a local 'logs' directory (the repository doesn't track or commit this...):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a .gitkeep file to the logs folder so it is tracked? I would rather have that than make the user create the directory themselves.

Copy link
Contributor Author

@RichardBruskiewich RichardBruskiewich Apr 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, will do; seems to be there, though. I guess we would also take it out of the .gitignore file above?

- `mkdir logs`

Once everything is installed, you can call
- `test-harness -h` to see available options
4 changes: 4 additions & 0 deletions requirements-runners.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
ARS_Test_Runner==0.0.2
ui-test-runner==0.0.1

# Dependency for the ui-test-runner
# not automatically pulled in
jq==1.6.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my bad. This can be removed and the ui-test-runner version should be bumped to 0.0.2 to include jq as a sub-dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll do that.

1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
httpx==0.25.0
pydantic==1.10.13
tqdm==4.66.1
Loading