fixed to make TestHarness full runnable (on my machine) #4
Conversation
…nstruction to (re-)create the root folder **`logs`** folder (not tracked by repo)
| @@ -21,5 +21,8 @@ The Test Harness is a CLI that you need to install: | |||
| - `pip install -r requirements-runners.txt` to install the Test Runners | |||
| - `pip install .` to install the Test Harness CLI | |||
|
|
|||
| Create a local 'logs' directory (the repository doesn't track or commit this...): | |||
There was a problem hiding this comment.
Can we add a .gitkeep file to the logs folder so it is tracked? I would rather have that than make the user create the directory themselves.
There was a problem hiding this comment.
ok, will do; seems to be there, though. I guess we would also take it out of the .gitignore file above?
| @@ -3,6 +3,8 @@ __pycache__ | |||
| *.egg-info | |||
| logs/ | |||
| Translator-Tests/ | |||
| build/ | |||
There was a problem hiding this comment.
Where does build/ come from?
There was a problem hiding this comment.
not sure. that's more common with Javascript builds, right - none here. I don't think it is relevant to this, unless the UI testing is somehow creating it, LOL. I'll try to remove it.
|
|
||
| # Dependency for the ui-test-runner | ||
| # not automatically pulled in | ||
| jq==1.6.0 |
There was a problem hiding this comment.
This is my bad. This can be removed and the ui-test-runner version should be bumped to 0.0.2 to include jq as a sub-dependency.
There was a problem hiding this comment.
Thanks. I'll do that.
|
Hi @maximusunc, |
|
I got a Windoze version of the code running by explicit importing of a mingw jq wheel built by a 3rd party. I've also implemented the other feedback above, in my current evolving "OneHopTest Integration" branch. For these reasons, I'm going to close this PR for this reason. |
To allow execution, added some missing pip dependencies plus README instruction to (re-)create the root folder
logsfolder (not tracked by repo)