Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1 skips errors, keeps track of error count, and reports error to ... #2

Merged
merged 1 commit into from
Jan 24, 2014

Conversation

KidA78
Copy link

@KidA78 KidA78 commented Jan 23, 2014

...cake shell, so caller can receive an error code with message containing the number of errors found

…to cake shell, so caller can receive an error code with message containing the number of errors found
@dchancogne
Copy link
Member

How is the called getting the error from the cake shell? Is $this->error() enough?

@KidA78
Copy link
Author

KidA78 commented Jan 23, 2014

http://book.cakephp.org/2.0/en/console-and-shells.html#Shell::error

According to this doc, $this->error() will internally call an exit with a return code of 1. If the return code is indeed 1, it should signal an error to any tool, and fail the build.

dchancogne added a commit that referenced this pull request Jan 24, 2014
fixes #1 skips errors, keeps track of error count, and reports error to ...
@dchancogne dchancogne merged commit cea3e74 into master Jan 24, 2014
@dchancogne
Copy link
Member

Looks good. Merging

@dchancogne dchancogne deleted the issue_1_fix branch January 24, 2014 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants