Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL Errors Are Not Handled #1

Closed
KidA78 opened this issue Jan 22, 2014 · 0 comments
Closed

MySQL Errors Are Not Handled #1

KidA78 opened this issue Jan 22, 2014 · 0 comments
Assignees
@KidA78

Comments

@KidA78
Copy link

KidA78 commented Jan 22, 2014

Seems that MySQL errors are not handled, and the version increments anyway. A suggested fix would be to catch the error, do nothing with the version, and return an error code to the caller, so the error could be detected by CI tools like Jenkins / Hudson.
@ghost ghost assigned dchancogne and KidA78 Jan 22, 2014
@KidA78 KidA78 closed this as completed in ba4fa73 Jan 24, 2014
dchancogne added a commit that referenced this issue Jan 24, 2014
@dchancogne
Merge pull request #2 from Traackr/issue_1_fix
cea3e74 
fixes #1 skips errors, keeps track of error count, and reports error to ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KidA78 KidA78

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dchancogne @KidA78