Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroy agent instances when disposed from cache #350

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

lukekarrys
Copy link
Collaborator

@lukekarrys lukekarrys commented Dec 4, 2024

Closes #325

Bumping the dependency is just a drive-by; this is mostly for
making sure that `Agent` instances in the cache are destroyed
when no longer reachable.
Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
proxy-agents ✅ Ready (Inspect) Visit Preview Dec 4, 2024 10:26pm

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: 053d500

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
proxy-agent Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukekarrys
Copy link
Collaborator Author

I can't figure out why CI is not running on #325. This PR is a copy of that one, but CI appears to be running on this one.

@lukekarrys lukekarrys force-pushed the lk/mongodb-js-agent-dispose branch from b896e46 to 053d500 Compare December 4, 2024 22:25
@lukekarrys lukekarrys changed the title lk/mongodb js agent dispose Destroy agent instances when disposed from cache Dec 4, 2024
@lukekarrys
Copy link
Collaborator Author

I also reverted the lru-cache update and opened #351 to discuss if that should be done as part of an engines change.

@lukekarrys lukekarrys merged commit ad68f63 into main Dec 5, 2024
13 of 14 checks passed
@lukekarrys lukekarrys deleted the lk/mongodb-js-agent-dispose branch December 5, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants