Destroy agent instances when disposed from cache (#350)

Co-authored-by: Anna Henningsen <[email protected]>
TooTallNate · Dec 5, 2024 · ad68f63 · ad68f63
1 parent a40e3ad
commit ad68f63
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 5 deletions.
diff --git a/.changeset/unlucky-vans-shout.md b/.changeset/unlucky-vans-shout.md
@@ -0,0 +1,5 @@
+---
+'proxy-agent': patch
+---
+
+Dispose of Agent instances in cache correctly
diff --git a/packages/proxy-agent/src/index.ts b/packages/proxy-agent/src/index.ts
@@ -83,7 +83,10 @@ export class ProxyAgent extends Agent {
 	/**
 	 * Cache for `Agent` instances.
 	 */
-	cache = new LRUCache<string, Agent>({ max: 20 });
+	cache = new LRUCache<string, Agent>({
+		max: 20,
+		dispose: (agent) => agent.destroy(),
+	});
 
 	connectOpts?: ProxyAgentOptions;
 	httpAgent: http.Agent;

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml