Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 1.16.2 and update requirements #17

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

jdblischak
Copy link
Collaborator

This PR does a few related things:

@jdblischak jdblischak requested a review from dudoslav November 7, 2024 02:06
@jdblischak jdblischak self-assigned this Nov 7, 2024

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ last_name }}-{{ version }}.tar.gz
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/{{ last_name }}-{{ version }}.tar.gz
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to pypi.org is a best practice that is being promoted by conda-forge

sha256: {{ sha256 }}
patches:
- remove-tiledbsoma-upper-bound.patch
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch I created for 1.15.0 is no longer needed because there is no longer an upper bound on tiledbsoma-py

- requests
- typing-extensions
- typing_extensions
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream uses typing_extensions with the underscore, so I updated it just to be consistent

recipe/meta.yaml Outdated
- requests
- typing-extensions
- typing_extensions
- s3fs >=2021.06.1
- scipy
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -44,6 +45,7 @@ test:
- cellxgene_census
requires:
- pip
- python ={{ python_min }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This runs the tests with the minimum supported Python version, which I really like since it will catch any potential problems early

@jdblischak
Copy link
Collaborator Author

Also note that this version 1.16.2 will not be able to be installed in the TileDB Cloud py39 environment since it requires py>=310. The goal is to install it in the updated py312 environment that is in progress

@jdblischak
Copy link
Collaborator Author

Confirmed that the version number is still working as expected (#12):

import: 'cellxgene_census'
+ python -c 'import cellxgene_census; print(cellxgene_census.__version__)'
1.16.2
+ pip check
No broken requirements found.

@jdblischak jdblischak merged commit 2fdf7d7 into TileDB-Inc:main Nov 7, 2024
3 checks passed
@jdblischak jdblischak deleted the 1.16.2 branch November 7, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants