-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 1.16.2 and update requirements #17
Conversation
…nda-forge-pinning 2024.11.06.14.03.29
|
||
package: | ||
name: {{ name|lower }} | ||
version: {{ version }} | ||
|
||
source: | ||
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ last_name }}-{{ version }}.tar.gz | ||
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/{{ last_name }}-{{ version }}.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to pypi.org is a best practice that is being promoted by conda-forge
sha256: {{ sha256 }} | ||
patches: | ||
- remove-tiledbsoma-upper-bound.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch I created for 1.15.0 is no longer needed because there is no longer an upper bound on tiledbsoma-py
- requests | ||
- typing-extensions | ||
- typing_extensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream uses typing_extensions
with the underscore, so I updated it just to be consistent
recipe/meta.yaml
Outdated
- requests | ||
- typing-extensions | ||
- typing_extensions | ||
- s3fs >=2021.06.1 | ||
- scipy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scipy <1.11
was a requirement for 1.6.0
https://github.com/chanzuckerberg/cellxgene-census/blob/v1.6.0/api/python/cellxgene_census/pyproject.toml#L40
472c4c1#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9aR18
But it is no longer a requirement, so I'm going to remove it
@@ -44,6 +45,7 @@ test: | |||
- cellxgene_census | |||
requires: | |||
- pip | |||
- python ={{ python_min }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This runs the tests with the minimum supported Python version, which I really like since it will catch any potential problems early
Also note that this version 1.16.2 will not be able to be installed in the TileDB Cloud py39 environment since it requires py>=310. The goal is to install it in the updated py312 environment that is in progress |
Confirmed that the version number is still working as expected (#12):
|
This PR does a few related things: