Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper bound for python dependency #15

Closed
wants to merge 3 commits into from
Closed

Remove upper bound for python dependency #15

wants to merge 3 commits into from

Conversation

dudoslav
Copy link

@dudoslav dudoslav commented Nov 6, 2024

Also increase lower bound to 3.9 since 3.8 is now "end of life"

Also increase lower bound to 3.9 since 3.8 is now "end of life"
@dudoslav dudoslav self-assigned this Nov 6, 2024
recipe/meta.yaml Outdated
@@ -23,12 +23,12 @@ build:

requirements:
host:
- python >=3.8,<3.12
- python >=3.9
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proactively (just so we don't get bitten by it) let's day < 3.13

@jdblischak
Copy link
Collaborator

cellxgene-census 1.15, the current version of the recipe, requires python >= 3.8, < 3.12

https://github.com/chanzuckerberg/cellxgene-census/blob/v1.15.0/api/python/cellxgene_census/pyproject.toml#L14

We need to update to cellxgene-census 1.16.2, which requires python >= 3.10, < 3.13

https://github.com/chanzuckerberg/cellxgene-census/blob/v1.16.2/api/python/cellxgene_census/pyproject.toml#L14

@jdblischak
Copy link
Collaborator

When updating to cellxgene-census 1.16.2, we'll also need to update the tiledbsoma-py requirement (we can also remove the patch I added in #14)

https://github.com/chanzuckerberg/cellxgene-census/blob/v1.16.2/api/python/cellxgene_census/pyproject.toml#L29

dependencies= [
    # NOTE: the tiledbsoma version must be >= to the version used in the Census builder, to
    # ensure that the assets are readable (tiledbsoma supports backward compatible reading).
    # Make sure this version does not fall behind the builder's tiledbsoma version.
    "tiledbsoma>=1.12.3,!=1.14.1",
    "anndata",
    "numpy>=1.23,<2.0",
    "requests",
    "typing_extensions",
    "s3fs>=2021.06.1",
]

@jdblischak
Copy link
Collaborator

Superseded by #17

@jdblischak jdblischak closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants