Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide on exposing subarray partitioner C API #1225

Closed
tdenniston opened this issue Apr 25, 2019 · 0 comments · Fixed by #1242
Closed

Decide on exposing subarray partitioner C API #1225

tdenniston opened this issue Apr 25, 2019 · 0 comments · Fixed by #1242
Labels
C API decision
Milestone
1.6.0

Comments

@tdenniston
Copy link
Contributor

PR #1197 added a new subarray partitioner helper class and an associated C API. It's not clear yet if this needs to be exposed via the C API. We should decide prior to 1.6 if we will keep the C API or not.
@tdenniston tdenniston added this to the 1.6.0 milestone Apr 25, 2019
@tdenniston tdenniston mentioned this issue Apr 25, 2019
Open
stavrospapadopoulos added a commit that referenced this issue May 3, 2019
@stavrospapadopoulos
Work on SubarrayPartitioner
cd04ca8 
- Removed tiledb_subarray_partitioner_t C API
- Added global order for single range in SubarrayPartitioner
- Refactored all tiledb_subarray_partitioner_t unit tests to test class SubarrayPartitioner instead.
- Added more test combinations for SubarrayPartitioner
- Added unit test helper functions that will help clean up all the other unit tests in the future.

Closes #1225
@stavrospapadopoulos stavrospapadopoulos mentioned this issue May 3, 2019
Merged
stavrospapadopoulos added a commit that referenced this issue May 3, 2019
@stavrospapadopoulos
Work on SubarrayPartitioner
10472da 
- Removed tiledb_subarray_partitioner_t C API
- Added global order for single range in SubarrayPartitioner
- Refactored all tiledb_subarray_partitioner_t unit tests to test class SubarrayPartitioner instead.
- Added more test combinations for SubarrayPartitioner
- Added unit test helper functions that will help clean up all the other unit tests in the future.

Closes #1225
stavrospapadopoulos added a commit that referenced this issue May 3, 2019
@stavrospapadopoulos
Work on SubarrayPartitioner
91039df 
- Removed tiledb_subarray_partitioner_t C API
- Added global order for single range in SubarrayPartitioner
- Refactored all tiledb_subarray_partitioner_t unit tests to test class SubarrayPartitioner instead.
- Added more test combinations for SubarrayPartitioner
- Added unit test helper functions that will help clean up all the other unit tests in the future.

Closes #1225
stavrospapadopoulos added a commit that referenced this issue May 3, 2019
@stavrospapadopoulos
Work on SubarrayPartitioner
45924be 
- Removed tiledb_subarray_partitioner_t C API
- Added global order for single range in SubarrayPartitioner
- Refactored all tiledb_subarray_partitioner_t unit tests to test class SubarrayPartitioner instead.
- Added more test combinations for SubarrayPartitioner
- Added unit test helper functions that will help clean up all the other unit tests in the future.

Closes #1225
stavrospapadopoulos added a commit that referenced this issue May 3, 2019
@stavrospapadopoulos
Work on SubarrayPartitioner
235911b 
- Removed tiledb_subarray_partitioner_t C API
- Added global order for single range in SubarrayPartitioner
- Refactored all tiledb_subarray_partitioner_t unit tests to test class SubarrayPartitioner instead.
- Added more test combinations for SubarrayPartitioner
- Added unit test helper functions that will help clean up all the other unit tests in the future.

Closes #1225
stavrospapadopoulos added a commit that referenced this issue May 3, 2019
@stavrospapadopoulos
Work on SubarrayPartitioner
cfa6205 
- Removed tiledb_subarray_partitioner_t C API
- Added global order for single range in SubarrayPartitioner
- Refactored all tiledb_subarray_partitioner_t unit tests to test class SubarrayPartitioner instead.
- Added more test combinations for SubarrayPartitioner
- Added unit test helper functions that will help clean up all the other unit tests in the future.

Closes #1225
stavrospapadopoulos added a commit that referenced this issue May 4, 2019
@stavrospapadopoulos
Work on SubarrayPartitioner
dffae3d 
- Removed tiledb_subarray_partitioner_t C API
- Added global order for single range in SubarrayPartitioner
- Refactored all tiledb_subarray_partitioner_t unit tests to test class SubarrayPartitioner instead.
- Added more test combinations for SubarrayPartitioner
- Added unit test helper functions that will help clean up all the other unit tests in the future.

Closes #1225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C API decision
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Work on SubarrayPartitioner TileDB-Inc/TileDB
1 participant
@tdenniston