Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on SubarrayPartitioner #1242

Merged
merged 1 commit into from
May 4, 2019
Merged

Conversation

stavrospapadopoulos
Copy link
Member

  • Removed tiledb_subarray_partitioner_t C API
  • Added global order for single range in SubarrayPartitioner
  • Refactored all tiledb_subarray_partitioner_t unit tests to test class SubarrayPartitioner instead.
  • Added more test combinations for SubarrayPartitioner
  • Added unit test helper functions that will help clean up all the other unit tests in the future.

Closes #1225

Copy link
Contributor

@tdenniston tdenniston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 👍 for the test helpers

@stavrospapadopoulos stavrospapadopoulos force-pushed the sp/subarray_partitioner branch 5 times, most recently from 235911b to cfa6205 Compare May 3, 2019 22:30
- Removed tiledb_subarray_partitioner_t C API
- Added global order for single range in SubarrayPartitioner
- Refactored all tiledb_subarray_partitioner_t unit tests to test class SubarrayPartitioner instead.
- Added more test combinations for SubarrayPartitioner
- Added unit test helper functions that will help clean up all the other unit tests in the future.

Closes #1225
@stavrospapadopoulos stavrospapadopoulos force-pushed the sp/subarray_partitioner branch from cfa6205 to dffae3d Compare May 4, 2019 15:33
@stavrospapadopoulos stavrospapadopoulos merged commit bb8d8f8 into dev May 4, 2019
@stavrospapadopoulos stavrospapadopoulos deleted the sp/subarray_partitioner branch May 4, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide on exposing subarray partitioner C API
3 participants