Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pinning wrong numpy version #1989

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

kounelisagis
Copy link
Member

@kounelisagis kounelisagis commented Jun 6, 2024

Right now, there is no single source of truth for dependencies. Until this is done, let's fix the required versions of numpy found in multiple project files. There are basically 5 different places where numpy version requirements should be specified:

  1. requirements.txt
  2. requirements_dev.txt
  3. requirements_wheel.txt
  4. pyproject.toml -> build-system -> requires
  5. pyproject.toml -> project -> dependencies

They can be merged into 3 categories:


Testing.

Python 3.8 (macos arm64)
Build: numpy-1.21.6
Installed with wheel: numpy-1.24.4

Python 3.8 (ubuntu)
Build: numpy-1.17.5
Installed with wheel: numpy-1.24.4

Python 3.9 (macos arm64)
Build: numpy-2.0.0rc2
Installed with wheel: numpy-1.26.4

*Wheels were installed in a fresh conda environment using pip install --no-cache-dir.


[sc-48530]

@kounelisagis kounelisagis force-pushed the agis/sc-48530/pinning-wrong-numpy-version branch from 29ac1bf to 7d67805 Compare June 7, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants