Skip to content

Commit

Permalink
Fix pinning wrong numpy version
Browse files Browse the repository at this point in the history
  • Loading branch information
kounelisagis committed Jun 10, 2024
1 parent f580dc7 commit 3f125a7
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 21 deletions.
13 changes: 4 additions & 9 deletions misc/requirements_wheel.txt
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
# numpy pinning for ABI forward-compatibility
numpy==1.16.5 ; python_version < "3.8" and platform_machine !='aarch64'
numpy==1.17.* ; python_version == "3.8" and platform_machine !='aarch64'
numpy==1.19.4 ; python_version == "3.9" and platform_machine !='aarch64'

# NOTE: oldest-supported-numpy (1.19.2) had forward ABI compat problems
numpy==1.20.* ; python_version < "3.10" and platform_machine=='aarch64'
numpy==1.21.* ; python_version == "3.10"
numpy>=1.23.2 ; python_version >= "3.11"
numpy==1.17.* ; python_version == '3.8' and platform_machine not in 'arm64|aarch64'
numpy==1.19.* ; python_version == '3.8' and platform_machine == 'aarch64'
numpy==1.21.* ; python_version == '3.8' and platform_machine == 'arm64'
numpy>=2.0.0rc2 ; python_version >= '3.9'

#-------------------------------

Expand Down
15 changes: 8 additions & 7 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ requires = [
"wheel",
"pybind11",
"Cython",
"numpy== 1.17.*,<2.0 ; python_version == '3.8' and platform_machine != 'aarch64'",
"numpy>=1.25 ; python_version >= '3.9'",
"numpy==1.17.* ; python_version == '3.8' and platform_machine not in 'arm64|aarch64'",
"numpy==1.19.* ; python_version == '3.8' and platform_machine == 'aarch64'",
"numpy==1.21.* ; python_version == '3.8' and platform_machine == 'arm64'",
"numpy>=2.0.0rc2 ; python_version >= '3.9'",
]
build-backend = "setuptools.build_meta"

Expand Down Expand Up @@ -40,11 +42,10 @@ classifiers=[
"Programming Language :: Python :: 3.12",
]
dependencies = [
"numpy==1.17.*,<2.0 ; python_version == '3.8' and platform_machine != 'aarch64'",
"numpy==1.19.4,<2.0 ; python_version == '3.9' and platform_machine != 'aarch64'",
"numpy==1.20.*,<2.0 ; python_version < '3.10' and platform_machine == 'aarch64'",
"numpy==1.21.*,<2.0 ; python_version == '3.10'",
"numpy>=1.23.2,<2.0 ; python_version >= '3.11'",
"numpy>=1.17 ; python_version == '3.8' and platform_machine not in 'arm64|aarch64'",
"numpy>=1.19 ; python_version == '3.8' and platform_machine == 'aarch64'",
"numpy>=1.21 ; python_version == '3.8' and platform_machine == 'arm64'",
"numpy>=1.25 ; python_version >= '3.9'",
]
dynamic = ["version"]

Expand Down
8 changes: 4 additions & 4 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
numpy>=1.16.5 ; python_version < "3.10" and platform_machine != 'aarch64'
numpy>=1.19.2 ; python_version < "3.10" and platform_machine == 'aarch64'
numpy>=1.21.0 ; python_version == "3.10"
numpy>=1.23.2 ; python_version >= "3.11"
numpy>=1.17 ; python_version == '3.8' and platform_machine not in 'arm64|aarch64'
numpy>=1.19 ; python_version == '3.8' and platform_machine == 'aarch64'
numpy>=1.21 ; python_version == '3.8' and platform_machine == 'arm64'
numpy>=1.25 ; python_version >= '3.9'
packaging

contextvars ;python_version<"3.7"
Expand Down
5 changes: 4 additions & 1 deletion requirements_dev.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
numpy >= 1.16.5
numpy>=1.17 ; python_version == '3.8' and platform_machine not in 'arm64|aarch64'
numpy>=1.19 ; python_version == '3.8' and platform_machine == 'aarch64'
numpy>=1.21 ; python_version == '3.8' and platform_machine == 'arm64'
numpy>=1.25 ; python_version >= '3.9'

# ------------------------------------------------
# ** MUST sync with misc/requirements_wheel.txt **
Expand Down

0 comments on commit 3f125a7

Please sign in to comment.