Use safe repr if ArraySchema
was not properly constructed
#1896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArraySchema
. We call the parentlt.ArraySchema
constructor at the beginning of__init__
which does set a valid context and creates the Pybind11 object. Then we set the other schema properties onto that object. If any of the other properties the user passed in are invalid (like thecell_order
ortile_order
), then simply checking the existence of a context does not work. Fortunately with theArraySchema
, there is anlt.ArraySchema._check
to ensure if it a properly constructor schemarepr
If Parent Pybind11 Constructor Fails #1545 all disappeared. I'm assuming a PR was not merged correctly after Use Saferepr
If Parent Pybind11 Constructor Fails #1545, but they have now been restored