Use Safe repr If Parent Pybind11 Constructor Fails
#1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This fixes a larger scale issue that was originally caught in the SOMA unit tests single-cell-data/TileDB-SOMA#653 * When the parent Pybind11 constructor fails, Pytest prints a backtrace of all the arguments in `super().__init__()` which includes the `self` object. Since the object does not exist, using the Pybind11 wrapped properties, namely `_filters`, results in a segfault * We use `self._ctx`, which is a property that only exists on the pure Python object, to check if the object has been properly instantiated
|
A few additional comments:
|
ihnorton
approved these changes
Jan 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
super().__init__()which includes theselfobject. Since the object does not exist, using the Pybind11 wrapped properties, namely_filters, results in a segfaultself._ctx, which is a property that only exists on the pure Python object, to check if the object has been properly instantiated