Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Group.close now takes in should_throw argument #1795

Closed
wants to merge 1 commit into from
Closed

[bugfix] Group.close now takes in should_throw argument #1795

wants to merge 1 commit into from

Conversation

nguyenv
Copy link
Collaborator

@nguyenv nguyenv commented Jun 24, 2023

  • Set default to True

@nguyenv nguyenv requested a review from ihnorton June 24, 2023 03:40
@nguyenv nguyenv mentioned this pull request Jun 24, 2023
Merged
@nguyenv
Copy link
Collaborator Author

nguyenv commented Jun 24, 2023

Opps didn't notice #1793 was already up.

@nguyenv nguyenv closed this Jun 24, 2023
@ihnorton ihnorton deleted the viviannugyen/group-close-fix branch June 25, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton Awaiting requested review from ihnorton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nguyenv